[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATE
From: |
pelzflorian (Florian Pelz) |
Subject: |
[bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button. |
Date: |
Sun, 04 Dec 2022 22:50:26 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello (
"( via Guix-patches" via <guix-patches@gnu.org> writes:
> * website/apps/base/templates/home.scm (home-t)[#:content]: Add a
> 'DOWNLOAD LATEST' button.
Good idea.
Would you add a copyright line or copyright disclaimer line and send an
updated patch?
> #:label (apply string-append
> (C_ "button" `("DOWNLOAD v" ,(latest-guix-version)
> "")))
> […]
> " " ; A space for readability in non-CSS browsers.
> + ,(button-big
> + #:label (apply string-append
> + (C_ "button" `("DOWNLOAD LATEST")))
In the DOWNLOAD LATEST button, could you remove the (apply string-append
and its now unmatched parenthesis?
It is a trick to concatenate the translations for "DOWNLOAD v", the
latest-guix-version and the translation for "". But for "DOWNLOAD
LATEST", it is unneeded.
And maybe untabify the lines you change.
Other than that, LGTM, thank you!
Regards,
Florian
- [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button., (, 2022/12/04
- [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button.,
pelzflorian (Florian Pelz) <=
- [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button., pelzflorian (Florian Pelz), 2022/12/04
- [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button., pelzflorian (Florian Pelz), 2022/12/04
- [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button., (, 2022/12/05
- [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button., pelzflorian (Florian Pelz), 2022/12/05
- [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button., zimoun, 2022/12/05
- [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button., pelzflorian (Florian Pelz), 2022/12/05
- [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button., pelzflorian (Florian Pelz), 2022/12/05
- [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button., zimoun, 2022/12/06
- [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button., pelzflorian (Florian Pelz), 2022/12/06
- [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button., zimoun, 2022/12/06