[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#59974] My GNU Health package
From: |
phodina |
Subject: |
[bug#59974] My GNU Health package |
Date: |
Tue, 13 Dec 2022 08:15:21 +0000 |
Hi Simon,
> > + (arguments
> > + (list #:phases #~(modify-phases %standard-phases
> > + (add-after 'install 'wrap-executable
> > + (lambda* (#:key inputs outputs #:allow-other-keys)
> > + (let ((out (assoc-ref outputs "out"))
> > + (qml "/lib/qt5/qml"))
> > + (wrap-program (string-append #$output
> > + "/bin/mygnuhealth")
> > + `("QML2_IMPORT_PATH" ":" prefix
> > + (,(string-append out qml)
> > + ,@(map (lambda (i)
> > + (string-append
> > + (assoc-ref inputs i) qml))
> > + '("kirigami"
> > + "qtdeclarative"
> > + "qtgraphicaleffects"
> > + "qtquickcontrols"
> > + "qtquickcontrols2"))))))))
>
>
> Here, I have another indentation. I do not have an opinion.
To me it's also reasonable. I just use 'guix style PKG' and fix the results if
they have weird indentation.
>
> > + (add-before 'check 'env-setup
> > + (lambda* _
>
> -^
> Why?
>
> Is lambda is not enough here?
I guess it was just copy paste of the the previous phase and I realized the
keywords aren't necessary. Fixed to use just lambda as suggested.
I also made some small changes to use gexp and 'out' variable in the phase
'wrap-executable'.
Thanks!
----
Petr
v2-0001-gnu-Add-mygnuhealth.patch
Description: Text Data