[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60120: [PATCH 01/28] gnu: Add ocaml-5.0.
From: |
Julien Lepiller |
Subject: |
bug#60120: [PATCH 01/28] gnu: Add ocaml-5.0. |
Date: |
Wed, 21 Dec 2022 22:11:53 +0100 |
Hi!
Thanks for the patch series. Pushed to master with the following fixes:
[01/28]
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/ocaml/ocaml")
> + (commit version)))
is missing a file-name field (guix lint complains about it), like this:
(file-name (git-file-name name version))
[04/28]
> +(define-public ocaml5.0-result
but this was not added to the properties of ocaml-result.
[06/28]
0.2.1 is the latest version.
[07/28]
> "https://gitlab.inria.fr/fpottier/monolith/-/archive/20210525/archive.tar.gz"
I think this might not be a stable archive, and guix lint complains
about the name, so I used git-fetch instead.
[08/28]
0.3.0 is the latest version.
[09/28]
There was a space at the end of description, and it contained typos.
You should use https instead of http when available. There was a tab in
the patch.
[20/28]
Description does not match our usual style. It seems you didn't define
ocaml-eio as public, because it fails to build. Would be great to fix,
wdyt?
[21/28]
Missing synopsis and description.
[22/28]
Description does not match our usual style.
[23/28]
Missing synopsis and description.
[24/28]
Missing synopsis and description.
- [bug#60120] [PATCH 16/28] gnu: Add ocaml-lwt-dllist., (continued)
- [bug#60120] [PATCH 16/28] gnu: Add ocaml-lwt-dllist., pukkamustard, 2022/12/16
- [bug#60120] [PATCH 21/28] gnu: Add ocaml5.0-eio-luv., pukkamustard, 2022/12/16
- [bug#60120] [PATCH 22/28] gnu: Add ocaml-uring., pukkamustard, 2022/12/16
- [bug#60120] [PATCH 19/28] gnu: ocaml-mdx: Move inputs to propagated-inputs., pukkamustard, 2022/12/16
- [bug#60120] [PATCH 28/28] gnu: Add ocaml5.0-merlin., pukkamustard, 2022/12/16
- [bug#60120] [PATCH 24/28] gnu: Add ocaml5.0-eio-main., pukkamustard, 2022/12/16
- [bug#60120] [PATCH 27/28] gnu: Add ocaml5.0-dot-merlin-reader., pukkamustard, 2022/12/16
- [bug#60120] [PATCH 26/28] gnu: Add ocaml5.0-merlin-lib., pukkamustard, 2022/12/16
- [bug#60120] [PATCH 23/28] gnu: Add ocaml5.0-eio-linux., pukkamustard, 2022/12/16
- [bug#60120] [PATCH 25/28] gnu: Update ocaml-merlin-lib to 4.7-414., pukkamustard, 2022/12/16
- bug#60120: [PATCH 01/28] gnu: Add ocaml-5.0.,
Julien Lepiller <=