[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#60224] [PATCH v3 10/11] gnu: u-boot-puma-rk3399: Use make-u-boot-su
From: |
Vagrant Cascadian |
Subject: |
[bug#60224] [PATCH v3 10/11] gnu: u-boot-puma-rk3399: Use make-u-boot-sunxi64-package. |
Date: |
Fri, 06 Jan 2023 09:09:31 -0800 |
On 2023-01-01, Maxim Cournoyer wrote:
> * gnu/packages/bootloaders.scm (u-boot-puma-rk3399): Use
> make-u-boot-sunxi64-package.
...
> diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
> index 960c5b4a88..18750c2ad4 100644
> --- a/gnu/packages/bootloaders.scm
> +++ b/gnu/packages/bootloaders.scm
> @@ -1090,23 +1090,7 @@ (define-public u-boot-cubietruck
> (make-u-boot-package "Cubietruck" "arm-linux-gnueabihf"))
>
> (define-public u-boot-puma-rk3399
> - (let ((base (make-u-boot-package "puma-rk3399" "aarch64-linux-gnu")))
> - (package
> - (inherit base)
> - (arguments
> - (substitute-keyword-arguments (package-arguments base)
> - ((#:phases phases)
> - `(modify-phases ,phases
> - (add-after 'unpack 'set-environment
> - (lambda* (#:key inputs #:allow-other-keys)
> - (setenv "BL31"
> - (search-input-file inputs "/bl31.elf"))))
> - ;; Phases do not succeed on the bl31 ELF.
> - (delete 'strip)
> - (delete 'validate-runpath)))))
> - (native-inputs
> - `(("firmware" ,arm-trusted-firmware-rk3399)
> - ,@(package-native-inputs base))))))
> + (make-u-boot-sunxi64-package "puma-rk3399" "aarch64-linux-gnu"))
This is definitely not a sunxi64 platform (sunxi ~= the community name
for allwinner platforms, and rk3399 is rockchip based), so either the
make-u-boot-sunx64-package has been overgeneralized and should be
renamed, or this is just not right...
live well,
vagrant
signature.asc
Description: PGP signature
- [bug#60224] [PATCH v3 01/11] gnu: make-u-boot-package: Add a u-boot argument and use gexps., Maxim Cournoyer, 2023/01/01
- [bug#60224] [PATCH v3 02/11] gnu: make-u-boot-package: Install .imx files., Maxim Cournoyer, 2023/01/01
- [bug#60224] [PATCH v3 03/11] gnu: make-uboot-package: Simplify build., Maxim Cournoyer, 2023/01/01
- [bug#60224] [PATCH v3 05/11] gnu: u-boot-pinebook-pro-rk3399: Remove input labels and use gexps., Maxim Cournoyer, 2023/01/01
- [bug#60224] [PATCH v3 07/11] gnu: make-u-boot-sunxi64-package: Use gexps and adjust file name., Maxim Cournoyer, 2023/01/01
- [bug#60224] [PATCH v3 04/11] gnu: make-u-boot-package: Allow disabling cross-compilation., Maxim Cournoyer, 2023/01/01
- [bug#60224] [PATCH v3 10/11] gnu: u-boot-puma-rk3399: Use make-u-boot-sunxi64-package., Maxim Cournoyer, 2023/01/01
- [bug#60224] [PATCH v3 10/11] gnu: u-boot-puma-rk3399: Use make-u-boot-sunxi64-package.,
Vagrant Cascadian <=
- [bug#60224] [PATCH v3 06/11] gnu: u-boot-firefly-rk3399: Use gexps and fix cross-build., Maxim Cournoyer, 2023/01/01
- [bug#60224] [PATCH v3 08/11] gnu: u-boot-rock64-rk3328: Fix build., Maxim Cournoyer, 2023/01/01
- [bug#60224] [PATCH v3 11/11] gnu: u-boot-rockpro64-rk3399: Fix build., Maxim Cournoyer, 2023/01/01
- [bug#60224] [PATCH v3 09/11] gnu: u-boot-sifive-unmatched: Use gexps and remove inputs., Maxim Cournoyer, 2023/01/01