[bug#60976] [PATCH] gnu: Add ditaa.

[zimoun]

Hi,

On Tue, 24 Jan 2023 at 18:50, Frank Pursel <frank.pursel@gmail.com> wrote:

> Another reason not to want to split this commit is because, per the
> reference manual, It seemed to me that this was also 'one set of
> related changes' enabling ditaa.  java-libbatik and java-jericho-html
> are unlikely to be used in support of anything else but cannot be
> commited separately without breaking ditaa.  I also suspect their
> purpose would quickly become unclear if mixed with other java
> packages.

No, there are independent.  This package java-jericho-html does not
depend on the others so it deserves its proper commit mentioning its
addition.

--8<---------------cut here---------------start------------->8---
+(define-public java-jericho-html

[...]

+      (native-inputs (list java-junit java-slf4j-api java-log4j-api
+                           java-commons-logging-minimal))
--8<---------------cut here---------------end--------------->8---

Then, it is similar for this other one:

--8<---------------cut here---------------start------------->8---
+(define-public java-libbatik

[...]

+    (native-inputs (list rhino java-xmlgraphics-commons libxslt
+                        java-jaxen java-junit java-jaxp java-xerces
+                        java-jdom quickjs))
--8<---------------cut here---------------end--------------->8---

Therefore, I would expect three commits, like this:

        gnu: Add java-jericho-html.
        gnu: Add java-libbatik.
        gnu: Add ditaa.


> If there were another application that also built upon the concrete
> java-libbatik then I think the argument for moving it into batik.scm
> would be stronger but don't think there is one because batik.scm
> remains more abstract.  I think that is ok.  'batik.scm' is java
> internally uses an svg api but ditaa leverages svg to produce other
> than svg output and is independent of java.  It is a tool that
> is likely to be used in non-java environments.

Well, I am not convinced by this argument about java-libbatik. :-)


Cheers,
simon