[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#61082] [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143.
From: |
Nicolas Goaziou |
Subject: |
[bug#61082] [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143. |
Date: |
Sat, 28 Jan 2023 17:30:06 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello,
conses <contact@conses.eu> writes:
> Because this might have been needed when the package didn't allow
> the pactl executable path to be found dynamically, but as per
> https://github.com/flexibeast/pulseaudio-control/commit/c8640fceb530ab7a1aa551d70f7ee222147d95cf
> this is no longer needed.
I don't think
(or (executable-find "pactl") "/usr/bin/pactl")
is equivalent to
(search-input-file inputs "/bin/pactl")
Some Emacs packages remove those `executable-find' calls, e.g.,
emacs-nov-el, emacs-emacsql-sqlite3, emacs-telega, etc.
It does make sense to keep this phase (but you can remove the initial
chmod call and the final #T), unless I'm missing something. We want the
Emacs package to always refer to its own Pulseaudio input, don't we?
Regards,
--
Nicolas Goaziou