[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60518: [PATCH] gnu: spirv-cross: Activate tests.
From: |
Ludovic Courtès |
Subject: |
bug#60518: [PATCH] gnu: spirv-cross: Activate tests. |
Date: |
Tue, 31 Jan 2023 23:57:03 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi,
Nicolas Graves <ngraves@ngraves.fr> skribis:
> * gnu/packages/vulkan.scm (spirv-cross):
> [arguments]: Add phase update-reference-shaders.
> [arguments]: Activate tests.
Applied, thanks!
Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
> Am Dienstag, dem 03.01.2023 um 16:48 +0100 schrieb Nicolas Graves:
>> * gnu/packages/vulkan.scm (spirv-cross):
>> [arguments]: Add phase update-reference-shaders.
>> [arguments]: Activate tests.
> Should be
>
> * gnu/packages/vulkan.scm (spirv-cross)[arguments]: Remove #:tests?.
> <#:phases>: Add ‘update-reference-shaders’.
I did that on their behalf (in general I think that’s what we should do,
it’s just more efficient and less frustrating for everyone).
>> + (lambda _
>> + (with-directory-excursion "../source"
>> + (invoke "./update_test_shaders.sh")))))))
> Instead of updating all the shaders, should we perhaps only update
>
> the three that are mentioned as failing?
Apparently the script is designed for this purpose.
Thanks,
Ludo’.