[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#60788] [PATCH] services: Add vnstat-service-type.
|
From: |
Bruno Victal |
|
Subject: |
[bug#60788] [PATCH] services: Add vnstat-service-type. |
|
Date: |
Thu, 9 Feb 2023 04:19:40 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 |
Hi Maxim,
On 2023-02-09 03:34, Maxim Cournoyer wrote:
> Two remaining comments from me:
>
> 1. I'd normalize all the configuration field names to lowercase, so
> max-BW and use-UTC? would become max-bw and use-utc?, for example.
No, this is intentional so that uglify+case-conversion yields correct
configuration directives.
> 2. I'd add a simple example vnstat usage example to the manual.
The service is "ready to be used" with the default values, so I didn't think
it'd add much value adding an example here. Do you think we should add one?
Cheers,
Bruno