[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#60788] [PATCH v5] services: Add vnstat-service-type.
From: |
Maxim Cournoyer |
Subject: |
[bug#60788] [PATCH v5] services: Add vnstat-service-type. |
Date: |
Fri, 10 Feb 2023 09:07:40 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi!
Bruno Victal <mirai@makinata.eu> writes:
[...]
> + vnstat-configuration
> + vnstat-configuration?
> + vnstat-service-type
> + vnstat-configuration-package
> + vnstat-configuration-database-dir
> + vnstat-configuration-5-minute-hours
> + vnstat-configuration-64bit-interface-counters
> + vnstat-configuration-always-add-new-interfaces?
> + vnstat-configuration-bandwidth-detection?
> + vnstat-configuration-bandwidth-detection-interval
> + vnstat-configuration-boot-variation
> + vnstat-configuration-check-disk-space?
> + vnstat-configuration-create-dirs?
> + vnstat-configuration-daemon-group
> + vnstat-configuration-daemon-user
> + vnstat-configuration-daily-days
> + vnstat-configuration-database-synchronous
> + vnstat-configuration-database-write-ahead-logging?
> + vnstat-configuration-hourly-days
> + vnstat-configuration-log-file
> + vnstat-configuration-max-bandwidth
> + vnstat-configuration-max-BW
^ Looks like you forgot to adjust to use the now all lowercase symbol
here.
> + vnstat-configuration-monthly-months
> + vnstat-configuration-month-rotate
> + vnstat-configuration-month-rotate-affects-years?
> + vnstat-configuration-offline-save-interval
> + vnstat-configuration-pid-file
> + vnstat-configuration-poll-interval
> + vnstat-configuration-rescan-database-on-save?
> + vnstat-configuration-save-interval
> + vnstat-configuration-save-on-status-change?
> + vnstat-configuration-time-sync-wait
> + vnstat-configuration-top-day-entries
> + vnstat-configuration-trafficless-entries?
> + vnstat-configuration-update-file-owner?
> + vnstat-configuration-update-interval
> + vnstat-configuration-use-logging
> + vnstat-configuration-use-UTC?
Ditto.
The rest LGTM.
--
Thanks,
Maxim