[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#61587] [PATCH v3 7/8] services: network-manager: Set service canoni
From: |
Bruno Victal |
Subject: |
[bug#61587] [PATCH v3 7/8] services: network-manager: Set service canonical-name to NetworkManager. |
Date: |
Tue, 7 Mar 2023 12:44:04 +0000 |
According to the semantics in [1], 'networking should be a "virtual service"
and NetworkManager its canonical-name. This does not influence
existing services and they should continue to use the 'networking symbol.
One visible change is that 'herd status' doesn't show 'networking' anymore,
instead listing 'NetworkManager' in its place but both symbols are can be used
to start and stop the same service.
Note: Though the symbol NetworkManager doesn't really conform with the overall
kebab-case
used throughout Guix, this is intentional as we really want to make it clear
that
that the symbol NetworkManager really refers to the software called
NetworkManager,
since it's a canonical name here. (rather than risk misleading the user to
interpret
the symbol network-manager as a symbol for some unspecific network management
software)
[1]: https://www.gnu.org/software/shepherd/manual/html_node/Jump-Start.html
* gnu/services/networking.scm (network-manager-shepherd-service): Make
'networking a
virtual service and set 'NetworkManager as its canonical name.
---
gnu/services/networking.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index 7cf92dc8c4..5899e0977b 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -1229,7 +1229,7 @@ (define (network-manager-shepherd-service config)
(vpn (vpn-plugin-directory vpn-plugins)))
(list (shepherd-service
(documentation "Run the NetworkManager.")
- (provision '(networking))
+ (provision '(NetworkManager networking))
(requirement `(user-processes dbus-system loopback
,@shepherd-requirement
;; TODO: iwd? is deprecated and should be passed
--
2.39.1
- [bug#61587] [PATCH v3 1/8] services: network-manager: Add 'shepherd-requirement' field., Bruno Victal, 2023/03/07
- [bug#61587] [PATCH v3 2/8] services: network-manager: Deprecate 'iwd?' field., Bruno Victal, 2023/03/07
- [bug#61587] [PATCH v3 4/8] services: connman: Add 'shepherd-requirement' field., Bruno Victal, 2023/03/07
- [bug#61587] [PATCH v3 6/8] services: network-manager: Await for NetworkManager to finish starting up., Bruno Victal, 2023/03/07
- [bug#61587] [PATCH v3 7/8] services: network-manager: Set service canonical-name to NetworkManager.,
Bruno Victal <=
- [bug#61587] [PATCH v3 3/8] services: connman: Use match-record and export accessors., Bruno Victal, 2023/03/07
- [bug#61587] [PATCH v3 5/8] services: connman: Deprecate 'iwd?' field., Bruno Victal, 2023/03/07
- [bug#61587] [PATCH v3 8/8] services: connman: Set service canonical-name to connman., Bruno Victal, 2023/03/07
- bug#61587: [PATCH v3 1/8] services: network-manager: Add 'shepherd-requirement' field., Ludovic Courtès, 2023/03/10