guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#63370] [PATCH] gnu: Add emacs-framemove.


From: Nicolas Goaziou
Subject: [bug#63370] [PATCH] gnu: Add emacs-framemove.
Date: Mon, 08 May 2023 18:15:38 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Hello,

Fabio Natali <me@fabionatali.com> writes:
>
> * gnu/packages/emacs-xyz.scm (emacs-framemove): New variable.

Thank you.

> Signed-off-by: Fabio Natali <me@fabionatali.com>

In Guix, you don't sign your own commits.

> +       (uri "https://www.emacswiki.org/emacs/download/framemove.el";)

This is an issue, because the URI is not stable. Please use GitHub
repository instead: <https://github.com/emacsmirror/framemove>.

> +    (description "@code{emacs-framemove} is similar to the
> @code{windmove.el}

Nicpicks: @code{emacs-framemove} -> Framemove and @code{windmove.el} -> 
Windmove.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou





reply via email to

[Prev in Thread] Current Thread [Next in Thread]