guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#63508] [PATCH 3/3] gnu: eudev: Always use MAC-based names for netwo


From: Liliana Marie Prikler
Subject: [bug#63508] [PATCH 3/3] gnu: eudev: Always use MAC-based names for network interfaces.
Date: Mon, 15 May 2023 06:31:52 +0200
User-agent: Evolution 3.46.4

Am Sonntag, dem 14.05.2023 um 14:42 -0700 schrieb Felix Lechner:
> The change here resulted in the recompilation of several seemingly
> unrelated packages such as Emacs and GTK. Perhaps those dependency
> relationships should be examined.
What?  GUI libraries and packages that depend on them need to be
rebuilt when we change the way we handle our (input, media) devices?! 
Can't have that!

>  gnu/packages/linux.scm | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 98e683bdb0..724c621fed 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -4173,6 +4173,12 @@ (define-public eudev
>                  (substitute* (string-append #$output
> "/lib/libudev.la")
>                    (("old_library=.*")
>                     "old_library=''\n")))))
> +          (add-before 'install 'net-name-mac
> +            (lambda _
> +              (use-modules (ice-9 regex))
> +              (substitute* "rules/80-net-name-slot.rules"
> +                (((regexp-quote "ID_NET_NAME_ONBOARD"))
Wherefore the regexp-quote?  There is no regexp to be found here, is
there?
> +                 "ID_NET_NAME_MAC"))))
I don't see how this change allows users *or upstream package
maintainers* to continue using onboard names as they have done for ages
and as they would want to continue to do.  I think you should
a) File a patch upstream to add ID_NET_NAME_MAC into net-name-
slot.rules
b) Add that patch to our eudev package with a reference to the upstream
bug report.

Cheers






reply via email to

[Prev in Thread] Current Thread [Next in Thread]