[bug#63499] [PATCH gnome-team 3/3] gnu: gtksourceview: Fix build.

[Maxim Cournoyer]

Hi,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Am Montag, dem 15.05.2023 um 09:49 -0400 schrieb Maxim Cournoyer:
>> Hello,
>> 
>> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>> 
>> > * gnu/packages/gtk.scm (gtksourceview)[#:phases]<pre-check>: Set
>> > “GDK_BACKEND”
>> > and “GTK_A11Y”.
>> > ---
>> >  gnu/packages/gtk.scm | 3 +++
>> >  1 file changed, 3 insertions(+)
>> > 
>> > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
>> > index de45eb3870..7d76610293 100644
>> > --- a/gnu/packages/gtk.scm
>> > +++ b/gnu/packages/gtk.scm
>> > @@ -616,6 +616,9 @@ (define-public gtksourceview
>> >                 ;; Tests require a running X server.
>> >                 (system (string-append Xvfb " :1 &"))
>> >                 (setenv "DISPLAY" ":1")
>> > +               ;; For GTK
>> 
>> Nitpick: Add a full stop (period) for standalone comments.  Perhaps
>> expound how these environment variables are useful to set ('For GTK'
>> leaves me wondering, as 'gtksourceview' already seems GTK-focused).
> Full disclosure, I don't quite understand what's wrong here myself, but
> with the upgrade to GTK 4.10, tests fail
> - due to GDK_BACKEND not being said for ??? reason
> - due to GTK_A11Y because GTK tries to spawn dbus and fails to connect.
>
>> 
> If there's a better wording for that, I'm all ears :)

Perhaps above setenv "GTK_BACKEND" mention "XXX: To avoid failures in
tests." and then above GTK_A11Y mention "Otherwise, GTK tries to spawn
D-Bus and fails to connect."

This captures everything you know; I think it's an improvement.

-- 
Thanks,
Maxim