[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#63691] [PATCH vREVISION] Add emacs-prism package
From: |
Nicolas Goaziou |
Subject: |
[bug#63691] [PATCH vREVISION] Add emacs-prism package |
Date: |
Thu, 25 May 2023 12:49:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello,
Maciej Kalandyk <m.kalandyk@outlook.com> writes:
> +(define-public emacs-prism
Thank you.
You need to add a proper commit message with your patch. For a new
variable, it is pretty much normalized:
gnu: Add emacs-prism.
* gnu/packages/emacs-xyz.scm (emacs-prism): New variable.
> + (package
> + (name "emacs-prism")
> + (version "0.3.1")
Version 0.3.2 was released yesterday, you may want to provide it
instead.
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/alphapapa/prism.el.git")
There's a habit of dropping ".git" suffix in URL, so the above should be:
(url "https://github.com/alphapapa/prism.el")
> + (commit version)))
> + (sha256
> + (base32
> + "1750s161ck83lcl36rm2jbkssbgpa9hfx1gbv2r582381q1p4kwp"))))
> + (build-system emacs-build-system)
> + (inputs (list emacs-dash))
> + (home-page "https://github.com/alphapapa/prism.el")
> + (synopsis
> + "Disperses lisp forms (and other languages) into a spectrum of color by
> depth")
I suggest:
Disperse Lisp forms...
> + (description
> + "prism is an \"rainbow-blocks\" like mode for Emacs, but it
> respects existing non-color face properties, and allows flexible
> configuration of faces and colors.")
I suggest:
Prism is a Rainbow Blocks-like mode for Emacs. It preserves non-color
face properties and allows configuration of faces and colors.
Also mind keeping line lengths below 80 columns.
Could you send an updated patch? (note it should be -v3 in the git
command line)?
Regards,
--
Nicolas Goaziou