[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#63877] [PATCH v2] gnu: services: web: Allow specifying extra php-fp
From: |
Bruno Victal |
Subject: |
[bug#63877] [PATCH v2] gnu: services: web: Allow specifying extra php-fpm environment variables. |
Date: |
Mon, 5 Jun 2023 04:44:37 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 |
On 2023-06-04 14:59, Timo Wilken wrote:
> @@ -1096,6 +1100,9 @@ (define php-fpm-shepherd-service
> #$@(if php-ini-file
> `("-c" ,php-ini-file)
> '()))
> + #:environment-variables
> + (append #$environment-variables
> + (default-environment-variables))
Ungexp-ing lists can be rather tricky since your snippet will expand to:
--8<---------------cut here---------------start------------->8---
...
#:environment-variables (append ("FOO=bar" ...)
(default-environment-variables))
...
--8<---------------cut here---------------end--------------->8---
Which is interpreted as a procedure call. (and results in a hanged shepherd)
You need to quote the list here:
--8<---------------cut here---------------start------------->8---
#:environment-variables (append '#$environment-variables
(default-environment-variables))
--8<---------------cut here---------------end--------------->8---
Bonus points if you can write a small system test for this. (see
gnu/tests/web.scm for inspiration)
For our purposes, a pair of HTTP servers where one of them uses a
self-signed certificate will suffice.
--
Furthermore, I consider that nonfree software must be eradicated.
Cheers,
Bruno.