[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#63909] [PATCH] home: Add inputrc service.
From: |
Ludovic Courtès |
Subject: |
[bug#63909] [PATCH] home: Add inputrc service. |
Date: |
Fri, 16 Jun 2023 15:40:09 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hi!
Efraim Flashner <efraim@flashner.co.il> skribis:
> * gnu/home/services/shells.scm (home-inputrc-service-type,
> home-inputrc-configuration): New variables.
> (serialize-inputrc-key-bindings, serialize-inputrc-variables,
> serialize-inputrc-conditional-constructs,
> serialize-inputrc-extra-content, generate-home-inputrc-documentation):
> New procedures.
Nice!
I’d like Andrew and ( to chime in more often :-) but here’s my take.
> +
> +;;;
> +;;; Documentation.
> +;;;
>
> (define (generate-home-shell-profile-documentation)
> (generate-documentation
> @@ -662,3 +798,10 @@ (define (generate-home-fish-documentation)
> `((home-fish-extension
> ,home-fish-extension-fields))
> 'home-fish-extension)))
> +
> +(define (generate-home-inputrc-documentation)
> + (string-append
> + (generate-documentation
> + `((home-inputrc-configuration
> + ,home-inputrc-configuration-fields))
> + 'home-inputrc-configuration)))
I don’t think we need to keep these procedures in the file.
Overall it LGTM, except for one thing: could you add it to
‘doc/guix.texi’? (The usual template is: an intro giving context and a
cross-reference to the upstream manual, one or two configuration
examples with an explanation, and then the reference.)
Thanks!
Ludo’.