guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#63987] Should jinx-mod.so be installed into /.../lib or into /.../s


From: Mekeor Melire
Subject: [bug#63987] Should jinx-mod.so be installed into /.../lib or into /.../share/emacs/site-lisp/...?
Date: Tue, 20 Jun 2023 22:04:34 +0000

2023-06-18 13:56 liliana.prikler@gmail.com:

Hi Mekeor,

Am Sonntag, dem 18.06.2023 um 11:34 +0000 schrieb Mekeor Melire:
> Hello Guix,
>
> my previous patch added a package definition for emacs-jinx. > The > package definition works by installing the accompanying > jinx-mod.so > into the package's $out/lib directory, and patching jinx.el so > that
> it loads that library from the correct path.
>
> The maintainer of the Emacs package suggests to rather install > jinx- > mod.so into $out/share/emacs/site-lisp/jinx-.../ instead, i.e. > right
> next to the .el-files:
> https://github.com/minad/jinx/issues/86#issuecomment-1596102645
>
> What do you think?
The way you did it SGTM. If you fear that it might shadow other shared libraries (probably an unnecessary fear, but who knows?), you could use lib/emacs instead. Other comments will come in a separate reply to
your first mail.

Stay tuned!

Daniel Mendler says: "My suggestion is that you put the library file [jinx-mod.so] in some appropriate directory, which must be on the load-path. I assume that there exists some convention on Guix on where to install native modules." https://github.com/minad/jinx/issues/86#issuecomment-1597221252

And I think they are right. We should have a convention about where to install 
native modules (.so-files) and add that directory to Emacs' load-path.

One approach would be to use $out/lib/emacs (or a new subdirectory of it). E.g. 
we would install jinx-mod.so into that path and Guix would add it to the 
EMACSLOADPATH environment-variable. (Currently, Guix only makes use of 
.../lib/emacs/native-site-lisp which is added to EMACSNATIVELOADPATH 
environment-variable.)

Another approach would be to agree on installing *.so-files into 
$out/share/site-lisp/PACKAGE-VERSION/ so that it is already present Emacs' 
load-path as is.

What do you think?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]