guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#64399] [PATCH] installer: Restore LatGrkCyr-8x16 console font depen


From: pelzflorian (Florian Pelz)
Subject: [bug#64399] [PATCH] installer: Restore LatGrkCyr-8x16 console font depending on language.
Date: Sat, 01 Jul 2023 19:03:24 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Hello Denys,

this patch looks good mostly good to me, except in my opinion,
`base-with-default-console-font' should be called `base' and
what is called `base' in your patch should be called `services'.
Consequently within the `let' body, the services field then could be set
as (services ,services) instead of (services ,base).

The one who commits the patch can fix it, but perhaps you could also
indent properly and untabify your change and then resend a v2 of the
patch?  In the manual’s Contributing section, the recommended way is to
use Emacs for automatic formatting, where you can press the tab key for
automatic indentation.

I have not tested yet.

I put the installer team in Cc.  If noone disagrees, I will make the
above changes, test, and commit this patch next weekend.

Regards,
Florian





reply via email to

[Prev in Thread] Current Thread [Next in Thread]