guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#64502] [PATCH] gnu: Add emacs-weyland-yutani-theme.


From: Nicolas Goaziou
Subject: [bug#64502] [PATCH] gnu: Add emacs-weyland-yutani-theme.
Date: Fri, 07 Jul 2023 00:14:24 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Hello,

Ahmad Draidi via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-weyland-yutani-theme): New
> variable.

Thank you. Some comments follow.

> +(define-public emacs-weyland-yutani-theme
> +  (let ((commit "e89a63a62e071180c9cdd9067679fadc3f7bf796")
> +        (revision "0"))
> +    (package
> +      (name "emacs-weyland-yutani-theme")
> +      (version (git-version "20210802.2251" revision commit))

Base version is actually "0.1", not "20210802.2251", per "Version"
keyword in main file.

> +      (description
> +       "Weyland Yutani is a dark Emacs theme based on the Alien movie 
> franchise")

The final full stop is missing.

> +      (license license:gpl3))))

License is actually gpl3+.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou





reply via email to

[Prev in Thread] Current Thread [Next in Thread]