[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#64551: [PATCH] svn-download: Use download-nar.
From: |
Christopher Baines |
Subject: |
bug#64551: [PATCH] svn-download: Use download-nar. |
Date: |
Tue, 11 Jul 2023 09:34:28 +0100 |
User-agent: |
mu4e 1.10.2; emacs 28.2 |
Ludovic Courtès <ludo@gnu.org> writes:
> Hi!
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> This should help if there are issues fetching from the source repository.
>>
>> * guix/svn-download.scm (svn-fetch): Use download-nar and adjust accordingly.
>
> […]
>
>> + (with-imported-modules
>> + (source-module-closure '((guix build svn)
>> + (guix build download-nar)
>> + (guix build utils)))
>> + (with-extensions (list guile-json guile-gnutls ;for (guix swh)
>> + guile-lzlib)
>
> “;for (guix build download-nar)” rather.
I copied this comment from (guix git-download), and I think it makes
sense. There shouldn't be any need from (guix build download-nar) to
have guile-json and guile-gnutls, it even specifically avoids using
https for this reason.
I think why these extra inputs is indeed just to import (guix swh as
it's required by (guix build download).
> Otherwise LGTM, thanks!
Great, I've pushed this to tex-team-next now as I'm hoping this will
help fix ci.guix.gnu.org building tex-team-next.
signature.asc
Description: PGP signature