[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#64746] [PATCH v2 2/3] pull: Tag commit argument with 'tag-or-commit
From: |
Simon Tournier |
Subject: |
[bug#64746] [PATCH v2 2/3] pull: Tag commit argument with 'tag-or-commit. |
Date: |
Wed, 16 Aug 2023 17:02:24 +0200 |
Hi Maxim,
On Tue, 15 Aug 2023 at 15:44, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> For compatibility with (guix git) procedures.
>
> * guix/scripts/pull.scm (channel-list): Also accept tag-or-commit tagged
> refspec.
> ---
I am not sure to understand these both changes.
>
> guix/scripts/pull.scm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm
> index ecd264d3fa..9b78d4b5ca 100644
> --- a/guix/scripts/pull.scm
> +++ b/guix/scripts/pull.scm
> @@ -166,7 +166,7 @@ (define %options
> (alist-delete 'repository-url result))))
> (option '("commit") #t #f
> (lambda (opt name arg result)
> - (alist-cons 'ref `(commit . ,arg) result)))
> + (alist-cons 'ref `(tag-or-commit . ,arg) result)))
Well, why not. :-)
> (option '("branch") #t #f
> (lambda (opt name arg result)
> (alist-cons 'ref `(branch . ,arg) result)))
> @@ -774,7 +774,8 @@ (define (channel-list opts)
> (if (guix-channel? c)
> (let ((url (or url (channel-url c))))
> (match ref
> - (('commit . commit)
> + ((or ('commit . commit)
> + ('tag-or-commit . commit))
Here, why not also add 'tag?. Hum, I am missing why this ’tag-or-commit
would be required.
Cheers,
simon
- [bug#64746] [PATCH v2 1/3] git: Clarify commit relation reference in doc., Maxim Cournoyer, 2023/08/15
- [bug#64746] [PATCH v2 3/3] scripts: time-machine: Error when attempting to visit too old commits., Maxim Cournoyer, 2023/08/15
- [bug#64746] [PATCH v2 2/3] pull: Tag commit argument with 'tag-or-commit., Maxim Cournoyer, 2023/08/15
- [bug#64746] [PATCH v2 2/3] pull: Tag commit argument with 'tag-or-commit.,
Simon Tournier <=
- [bug#64746] [PATCH v2 2/3] pull: Tag commit argument with 'tag-or-commit., Maxim Cournoyer, 2023/08/16
- [bug#64746] [PATCH v2 2/3] pull: Tag commit argument with 'tag-or-commit., Simon Tournier, 2023/08/17
- [bug#64746] [PATCH v2 2/3] pull: Tag commit argument with 'tag-or-commit., Maxim Cournoyer, 2023/08/17
- [bug#64746] [PATCH v2 2/3] pull: Tag commit argument with 'tag-or-commit., Simon Tournier, 2023/08/17
- [bug#64746] [PATCH 2/2] scripts: time-machine: Error when attempting to visit too old commits., Maxim Cournoyer, 2023/08/22
- [bug#64746] [PATCH 2/2] scripts: time-machine: Error when attempting to visit too old commits., Simon Tournier, 2023/08/23