guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#65126] [PATCH] gnu: exiv2: Get rid of reference to GCC.


From: Ludovic Courtès
Subject: [bug#65126] [PATCH] gnu: exiv2: Get rid of reference to GCC.
Date: Wed, 16 Aug 2023 20:07:50 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Hi!

iyzsong@envs.net skribis:

> From: 宋文武 <iyzsong@member.fsf.org>
>
> This fixes <https://issues.guix.gnu.org/57677>.

s/This fixes/Fixes/, for consistency.

> +         (add-after 'unpack 'patch-gcc-reference
> +           (lambda _
> +             ;; _GLIBCXX_ASSERTIONS brings reference to GCC.
> +             (substitute* "cmake/compilerFlags.cmake"
> +               (("add_compile_options[(]-Wp,-D_GLIBCXX_ASSERTIONS[)]")
> +                ""))))

Well done!  According to
<https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_macros.html>,
‘_GLIBCXX_ASSERTIONS’ enables various run-time checks; I guess disabling
it is acceptable.

So… LGTM!

Thanks,
Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]