[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#65352] Fix time-machine and network
From: |
Ludovic Courtès |
Subject: |
[bug#65352] Fix time-machine and network |
Date: |
Mon, 21 Aug 2023 16:00:06 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> Simon Tournier <zimon.toutoune@gmail.com> writes:
>
>> * guix/scripts/pull.scm (channel-list): Remove commit pair reference
>> specification.
>> ---
>> guix/scripts/pull.scm | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/guix/scripts/pull.scm b/guix/scripts/pull.scm
>> index 9b78d4b5ca..616926ee0b 100644
>> --- a/guix/scripts/pull.scm
>> +++ b/guix/scripts/pull.scm
>> @@ -774,8 +774,7 @@ (define (channel-list opts)
>> (if (guix-channel? c)
>> (let ((url (or url (channel-url c))))
>> (match ref
>> - ((or ('commit . commit)
>> - ('tag-or-commit . commit))
>> + (('tag-or-commit . commit)
>> (channel (inherit c)
>> (url url) (commit commit) (branch #f)))
>> (('branch . branch)
>
> Not that channel-list is a public API, so this is effectively changing
> the contract, no?
Yes, but it’s really meant to be used internally, where it’s either
'tag-or-commit or 'branch in practice. So to me either way is fine.
Thanks,
Ludo’.
- [bug#64746] [PATCH 2/2] scripts: time-machine: Error when attempting to visit too old commits., (continued)
- [bug#64746] [PATCH 2/2] scripts: time-machine: Error when attempting to visit too old commits., Simon Tournier, 2023/08/16
- [bug#64746] [PATCH 2/2] scripts: time-machine: Error when attempting to visit too old commits., Maxim Cournoyer, 2023/08/16
- [bug#65352] Fix time-machine and network, Simon Tournier, 2023/08/17
- [bug#65352] [PATCH 1/2] guix: git: Fix the procedure reference-available?., Simon Tournier, 2023/08/17
- [bug#65352] [PATCH 2/2] scripts: pull: Remove unused reference pair., Simon Tournier, 2023/08/17
- [bug#65352] Fix time-machine and network, Maxim Cournoyer, 2023/08/17
- [bug#65352] Fix time-machine and network, Simon Tournier, 2023/08/17
- [bug#65352] Fix time-machine and network, Maxim Cournoyer, 2023/08/22
- [bug#65352] Fix time-machine and network, Simon Tournier, 2023/08/23
- [bug#65352] Fix time-machine and network, Maxim Cournoyer, 2023/08/23
- [bug#65352] Fix time-machine and network,
Ludovic Courtès <=
- [bug#65352] Fix time-machine and network, Maxim Cournoyer, 2023/08/21
- [bug#65352] Fix time-machine and network, Ludovic Courtès, 2023/08/22
- [bug#65352] Fix time-machine and network, Maxim Cournoyer, 2023/08/22
- [bug#65352] Fix time-machine and network, Ludovic Courtès, 2023/08/21