[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#65204] [PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher.
From: |
Hilton Chain |
Subject: |
[bug#65204] [PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher. |
Date: |
Mon, 21 Aug 2023 23:20:32 +0800 |
Hi Ludo,
On Mon, 21 Aug 2023 22:03:27 +0800,
Ludovic Courtès wrote:
>
> > * gnu/packages/golang.scm (go-github-com-tdewolff-parse-v2)[#:phases]: Add
> > phase 'regenerate-hash.
> > [native-inputs]: Add go-github-com-tdewolff-hasher.
>
> [...]
>
> > + (list #:import-path "github.com/tdewolff/parse/v2"
> > + #:phases
> > + #~(modify-phases %standard-phases
> > + (add-after 'unpack 'regenerate-hash
> > + (lambda* (#:key import-path #:allow-other-keys)
> > + (for-each
> > + (lambda (dir)
> > + (with-directory-excursion
> > + (format #f "src/~a/~a" import-path dir)
> > + (make-file-writable "hash.go")
> > + (format #t "Generating `hash.go' for ~a...~%" dir)
> > + (invoke "go" "generate")))
>
> Maybe you can remove ‘hash.go’ in a snippet, for good measure, and add a
> comment clarifying that it’s a generated file.
>
> Otherwise the patch series LGTM!
Source data to generate the hash is also written in `hash.go', so it's
not possible to remove it.
Thanks
- [bug#65204] [PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher., Hilton Chain, 2023/08/10
- [bug#65204] [PATCH 1/6] gnu: Add go-github-com-dgryski-go-metro., Hilton Chain, 2023/08/10
- [bug#65204] [PATCH 4/6] gnu: Add go-github-com-tdewolff-hasher., Hilton Chain, 2023/08/10
- [bug#65204] [PATCH 2/6] gnu: Add go-github-com-dgryski-go-mph., Hilton Chain, 2023/08/10
- [bug#65204] [PATCH 3/6] gnu: Add go-github-com-cespare-mph., Hilton Chain, 2023/08/10
- [bug#65204] [PATCH 5/6] gnu: go-github-com-tdewolff-parse-v2: Regenerate hash., Hilton Chain, 2023/08/10
- [bug#65204] [PATCH 6/6] gnu: go-github-com-tdewolff-minify-v2: Regenerate hash., Hilton Chain, 2023/08/10