guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#65085] [PATCH 12/13] gnu: Add go-github-com-json-iterator-go


From: Maxim Cournoyer
Subject: [bug#65085] [PATCH 12/13] gnu: Add go-github-com-json-iterator-go
Date: Fri, 01 Sep 2023 08:08:22 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

tags 65072 + moreinfo
quit

Hi Fries,

Thank you for your contribution.

Fries <fries1234@protonmail.com> writes:

> * gnu/packages/golang.scm (go-github-com-chyzer-test): New variable.
> ---
>  gnu/packages/golang.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index d99f76dc7d..ef82f0aa1b 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -2113,6 +2113,32 @@ (define-public go-github-com-dhowett-go-plist
>  types.")
>        (license license:giftware))))
>  
> +(define-public go-github-com-chzyer-test
> +  (package
> +    (name "go-github-com-chzyer-test")
> +    (version "1.0.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/chzyer/test";)
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1axdlcnx2qjsn5wsr2pr1m0w0a8k4nk5kkrngh742fgh81vzzy8s"))))
> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "github.com/chzyer/test"
> +       #:phases
> +       ;; Tests relating to a in-memory disk fail due to a Segfault.
> +       (modify-phases %standard-phases
> +         (delete 'check))))

This should be minimally investigated, and ideally an issue created on
upstream issue tracker and an URL added next to the comment to track its
resolution, e.g:

;; Tests relating to a in-memory disk fail due to a segfault (see:
;; $URL).

Also taking the comments from parens into account, could you please send
a v2 to this same issue (65072@debbugs.gnu.org) ?

-- 
Thanks,
Maxim





reply via email to

[Prev in Thread] Current Thread [Next in Thread]