[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#65732] [PATCH 0/2] Add the Build Farm Front-End
From: |
Ludovic Courtès |
Subject: |
[bug#65732] [PATCH 0/2] Add the Build Farm Front-End |
Date: |
Thu, 14 Sep 2023 17:02:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Christopher Baines <mail@cbaines.net> skribis:
> This is intended to replace the functionality of the Guix Build Coordinator
> queue builds script, and also provide a web interface for build farms.
>
> * gnu/services/guix.scm (<bffe-configuration>): New record type.
> (bffe-configuration, bffe-configuration?,
> bffe-configuration-package,
> bffe-configuration-user,
> bffe-configuration-group,
> bffe-configuration-arguments
> bffe-configuration-extra-environment-variables): New procedures.
> (bffe-service-type): New variable.
> * gnu/tests/guix.scm (%test-bffe): New variable.
> * doc/guix.texi (Guix Services): Document the new service.
Overall LGTM.
Nitpick: you can make lines a bit longer, for instance:
> +(define (bffe-activation config)
> + #~(begin
> + (use-modules (guix build utils))
> +
> + (define %user
> + (getpw #$(bffe-configuration-user
> + config)))
‘config’ can be moved to the previous line.
> + (chown "/var/run/bffe"
> + (passwd:uid %user)
> + (passwd:gid %user))))
This can be a single line.
> + (extensions
> + (list
> + (service-extension shepherd-root-service-type
> + bffe-shepherd-services)
And: (list (service-extension …
Ludo’.