guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#65479] [PATCH core-updates v2 01/62] gnu: docbook-xml: Fix installa


From: Maxim Cournoyer
Subject: [bug#65479] [PATCH core-updates v2 01/62] gnu: docbook-xml: Fix installation paths.
Date: Thu, 05 Oct 2023 15:21:38 -0400
User-agent: Gnus/5.13 (Gnus v5.13)

Hi!

Nice series!

Bruno Victal <mirai@makinata.eu> writes:

> Using xml/dtd/docbook as installation path had two problems:
> * The paths would conflict in profile, which made it impossible
> for two different docbook-xml packages to coexist within the XML_CATALOG_FILES
> variable.
> * It was technically incorrect since non-DTD schemas were also placed here.
>
> This commit makes docbook-xml use versioned paths instead.
>
> * gnu/packages/docbook.scm
> (docbook-xml-package, docbook-xml-4.x-package): New procedure.
> (docbook-xml): Make docbook-xml an alias for docbook-xml-5.1.
> (docbook-xml-5.1): New variable.
> (docbook-xml-4.5, docbook-xml-4.4, docbook-xml-4.3, docbook-xml-4.2)
> (docbook-xml-4.1.2): Refactor to use docbook-xml-4.x-package procedure.

I think it'd be a bit more conventional to rename docbook-xml-package to
'make-docbook-xml'.  It'd be nice if instead of having to have to
manually override the install phase for each version the generator would
handled that.  Perhaps it could also accept as an arguments a list of
the files to install, in the format understood by the copy-build-system.

This should reduce the template inheritance & overriding boilerplate
needed.

-- 
Thanks,
Maxim





reply via email to

[Prev in Thread] Current Thread [Next in Thread]