[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#42146] [PATCH core-updates 1/?] build: substitute: Don't fail silen
From: |
Ludovic Courtès |
Subject: |
[bug#42146] [PATCH core-updates 1/?] build: substitute: Don't fail silently. |
Date: |
Thu, 19 Oct 2023 22:40:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hi,
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> * etc/teams.scm.in (<regexp*>, make-regexp*, regexp*-exec): Move to...
> * guix/build/utils.scm: ... here.
> (list-matches*): New procedure.
[...]
> +++ b/guix/build/utils.scm
[...]
> +;;;
> +;;; Extend regexp objects with a pattern field.
> +;;;
> +(define-record-type <regexp*>
> + (%make-regexp* pat flag rx)
> + regexp*?
> + (pat regexp*-pattern) ;the regexp pattern, a string
> + (flag regexp*-flag) ;regexp flags
> + (rx regexp*-rx)) ;the compiled regexp object
> +
> +;;; Work around regexp implementation.
> +;;; This record allows to track the regexp pattern and then display it.
> +(define* (make-regexp* pat #:optional (flag regexp/extended))
I’m skeptical about the concrete benefits. I would not include it in
(guix build utils), or at least not in this patch series.
(I tend to be super conservative about (guix build utils) because we
rarely get a chance to change it.)
Ludo’.