[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#66525] [PATCH v2 06/10] gnu: polkit: Remove dependency on (guix bui
From: |
Ludovic Courtès |
Subject: |
[bug#66525] [PATCH v2 06/10] gnu: polkit: Remove dependency on (guix build syscalls). |
Date: |
Sun, 22 Oct 2023 15:43:30 +0200 |
Having a dependency on (guix build syscalls) this deep in the stack
would make it much harder to change syscalls.scm.
* gnu/packages/polkit.scm (polkit)[arguments]: Remove #:imported-modules.
Remove (guix build syscalls) from #:modules.
Rewrite ‘check’ phase to reap processes from the build process.
[native-inputs]: Remove TINI.
---
gnu/packages/polkit.scm | 35 +++++++++++++++--------------------
1 file changed, 15 insertions(+), 20 deletions(-)
diff --git a/gnu/packages/polkit.scm b/gnu/packages/polkit.scm
index 6fe7824a57..2f733dd703 100644
--- a/gnu/packages/polkit.scm
+++ b/gnu/packages/polkit.scm
@@ -95,10 +95,7 @@ (define-public polkit
(build-system meson-build-system)
(arguments
(list
- #:imported-modules `(,@%meson-build-system-modules
- (guix build syscalls))
#:modules '((guix build meson-build-system)
- (guix build syscalls)
(guix build utils)
(ice-9 match))
#:configure-flags
@@ -130,24 +127,23 @@ (define-public polkit
(replace 'check
(lambda* (#:key tests? test-options #:allow-other-keys)
(when tests?
- ;; Run the test suite through tini to ensure signals are
- ;; properly handled and zombie processes reaped.
(match (primitive-fork)
(0 ;child process
- (set-child-subreaper!)
- ;; Use tini so that signals are properly handled and
- ;; doubly-forked processes get reaped; otherwise,
- ;; python-dbusmock would waste time polling for the dbus
- ;; processes it spawns to be reaped, in vain.
- (apply execlp "tini" "--"
- "meson" "--" "test" "-t" "0" "--print-errorlogs"
+ (apply execlp "meson" "meson"
+ "test" "-t" "0" "--print-errorlogs"
test-options))
- (pid
- (match (waitpid pid)
- ((_ . status)
- (unless (zero? status)
- (error "`meson test' exited with status"
- status))))))))))))
+ (meson-pid
+ ;; Reap child processes; otherwise, python-dbusmock would
+ ;; waste time polling for the dbus processes it spawns to
+ ;; be reaped, in vain.
+ (let loop ()
+ (match (waitpid WAIT_ANY)
+ ((pid . status)
+ (if (= pid meson-pid)
+ (unless (zero? status)
+ (error "`meson test' exited with status"
+ status))
+ (loop)))))))))))))
(inputs
(list duktape expat elogind linux-pam nspr))
(propagated-inputs
@@ -162,8 +158,7 @@ (define-public polkit
perl
pkg-config
python
- python-dbusmock
- tini))
+ python-dbusmock))
(home-page "https://www.freedesktop.org/wiki/Software/polkit/")
(synopsis "Authorization API for privilege management")
(description "Polkit is an application-level toolkit for defining and
--
2.41.0
- [bug#66525] [PATCH 1/7] gnu: mutter: Remove dependency on (guix build syscalls)., (continued)
- [bug#66525] [PATCH 1/7] gnu: mutter: Remove dependency on (guix build syscalls)., Bruno Victal, 2023/10/13
- [bug#66525] [PATCH 1/7] gnu: mutter: Remove dependency on (guix build syscalls)., Maxim Cournoyer, 2023/10/14
- [bug#66525] [PATCH 1/7] gnu: mutter: Remove dependency on (guix build syscalls)., Ludovic Courtès, 2023/10/14
- [bug#66525] [PATCH 1/7] gnu: mutter: Remove dependency on (guix build syscalls)., Maxim Cournoyer, 2023/10/15
- [bug#66525] [PATCH 1/7] gnu: mutter: Remove dependency on (guix build syscalls)., Ludovic Courtès, 2023/10/16
- [bug#66525] [PATCH 1/7] gnu: mutter: Remove dependency on (guix build syscalls)., Maxim Cournoyer, 2023/10/16
- [bug#66525] [PATCH v2 00/10] Remove dependency of polkit, python-dbusmock, etc. on (guix build syscalls), Ludovic Courtès, 2023/10/22
- [bug#66525] [PATCH v2 01/10] gnu: mutter: Remove dependency on (guix build syscalls)., Ludovic Courtès, 2023/10/22
- [bug#66525] [PATCH v2 06/10] gnu: polkit: Remove dependency on (guix build syscalls).,
Ludovic Courtès <=
- [bug#66525] [PATCH v2 07/10] gnu: public-inbox: Remove dependency on (guix build syscalls)., Ludovic Courtès, 2023/10/22
- [bug#66525] [PATCH v2 05/10] gnu: python-dbusmock: Use ‘search-input-file’., Ludovic Courtès, 2023/10/22
- [bug#66525] [PATCH v2 03/10] gnu: python-dbusmock: Remove dependency on (guix build syscalls)., Ludovic Courtès, 2023/10/22
- [bug#66525] [PATCH v2 04/10] gnu: python-dbusmock: Rewrite phases as a gexp., Ludovic Courtès, 2023/10/22
- [bug#66525] [PATCH v2 02/10] gnu: python-ipykernel: Remove dependency on (guix build syscalls)., Ludovic Courtès, 2023/10/22
- [bug#66525] [PATCH v2 09/10] build-system/android-ndk: Remove dependency on (guix build syscalls)., Ludovic Courtès, 2023/10/22
- [bug#66525] [PATCH v2 08/10] build-system/ant: Remove dependency on (guix build syscalls)., Ludovic Courtès, 2023/10/22
- [bug#66525] [PATCH v2 10/10] build-system/dub: Remove dependency on (guix build syscalls)., Ludovic Courtès, 2023/10/22
- [bug#66525] [PATCH v2 00/10] Remove dependency of polkit, python-dbusmock, etc. on (guix build syscalls), Maxim Cournoyer, 2023/10/22
- [bug#66525] [PATCH v2 00/10] Remove dependency of polkit, python-dbusmock, etc. on (guix build syscalls), Ludovic Courtès, 2023/10/23