[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#66823] [PATCH gnome-team 1/4] gnu: feedbackd: Update to 0.2.1.
From: |
Maxim Cournoyer |
Subject: |
[bug#66823] [PATCH gnome-team 1/4] gnu: feedbackd: Update to 0.2.1. |
Date: |
Tue, 31 Oct 2023 09:54:41 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hello,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Am Sonntag, dem 29.10.2023 um 17:32 +0100 schrieb Vivien Kraus:
>> The package now uses a “gmobile” submodule that should be included
>> as-is.
>>
>> * gnu/packages/gnome.scm (feedbackd): Update to 0.2.1.
>> [#:phases 'unpack-gmobile]: New phase.
> Should be: [#:phases]: Add ‘unpack-gmobile’. You might want to look
> into building this with an already installed gmobile; meson ought to
> support that use case.
+1, or at least...
>> Change-Id: I06521c1673efb6aea1d163410fdf3d0206b57d8a
>> ---
>> gnu/packages/gnome.scm | 21 +++++++++++++++++++--
>> 1 file changed, 19 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index a86ddc34b3..8092715795 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -12918,7 +12918,7 @@ (define-public jsonrpc-glib
>> (define-public feedbackd
>> (package
>> (name "feedbackd")
>> - (version "0.0.0+git20200527")
>> + (version "0.2.1")
>> (source (origin
>> (method git-fetch)
>> (uri (git-reference
>> @@ -12927,8 +12927,25 @@ (define-public feedbackd
>> (file-name (git-file-name name version))
>> (sha256
>> (base32
>> -
>> "1wbkzxnqjydfgjvp7vz4ghczcz740zcb1yn90cb6gb5md4n6qx2y"))))
>> +
>> "1acwpb8cgzyvzriphrb42k3d7njwcn88j66i5wz75yx2sbfaf93q"))))
>> (build-system meson-build-system)
>> + (arguments
>> + (list
>> + #:phases
>> + #~(modify-phases %standard-phases
>> + (add-after 'unpack 'unpack-gmobile
... a comment here explaining why we can't simply use gmobile as a
library (build system limitation? link to upstream issue?) is needed.
Otherwise it LGTM.
--
Maxim
- [bug#66823] [PATCH gnome-team 0/4] Add GNOME Calls, Vivien Kraus, 2023/10/29
- [bug#66823] [PATCH gnome-team 1/4] gnu: feedbackd: Update to 0.2.1., Vivien Kraus, 2023/10/29
- [bug#66823] [PATCH gnome-team 3/4] gnu: Add libcallaudio., Vivien Kraus, 2023/10/29
- [bug#66823] [PATCH gnome-team 4/4] gnu: Add calls., Vivien Kraus, 2023/10/29
- [bug#66823] [PATCH gnome-team 2/4] gnu: Add sofia-sip., Vivien Kraus, 2023/10/29
- [bug#66823] [PATCH gnome-team v2 0/6] Add GNOME Calls, slightly better, Vivien Kraus, 2023/10/29