guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#67903] [PATCH] gnu: libcgroup: Update to 3.1.0.


From: Hilton Chain
Subject: [bug#67903] [PATCH] gnu: libcgroup: Update to 3.1.0.
Date: Fri, 05 Jan 2024 13:24:58 +0800

Hi,

On Sun, 24 Dec 2023 13:27:13 +0800,
郑俊杰 wrote:
>
>
>
> > 在 2023年12月19日,22:51,Hilton Chain via Guix-patches via 
> > <guix-patches@gnu.org> 写道:
> >
> > * gnu/packages/linux.scm (libcgroup): Update to 3.1.0.
> > [arguments]<#:configure-flags>: Disable systemd.
> >
> > Change-Id: I67fe380ebdf91ca254b3365b7f237a3d9ad4f0a5
> > ---
> > gnu/packages/linux.scm | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> > index 3ca756dead..c4c366e21f 100644
> > --- a/gnu/packages/linux.scm
> > +++ b/gnu/packages/linux.scm
> > @@ -8798,7 +8798,7 @@ (define-public fbgrab
> > (define-public libcgroup
> >   (package
> >     (name "libcgroup")
> > -    (version "2.0.2")
> > +    (version "3.1.0")
> >     (home-page "https://github.com/libcgroup/libcgroup";)
> >     (source
> >      (origin
> > @@ -8806,14 +8806,15 @@ (define-public libcgroup
> >        (uri (string-append home-page "/releases/download/v"
> >                            version "/" name "-" version ".tar.gz"))
>
> Can we switch to git-fetch?

Is there any good reason?

> And don’t use home-page in source.

No problem.

> >        (sha256
> > -        (base32 "1y0c9ncsawamj77raiw6qkbm5cdsyvhjb2mvgma1kxmgw0r3pxlf"))))
> > +        (base32 "0n0jkvmagw14vgwx3j5b6vv5h25lasrg2a7xihq9h11ww2qw8vlp"))))
> >     (build-system gnu-build-system)
> >     (arguments
> >      ;; Tests are virtualized with lxc, it is not very feasible
> >      ;; to make them executable under guix build. Also, note that
> >      ;; origin is using source tarball release which is prepared
> >      ;; after testing.
> > -     `(#:tests? #f))
> > +     `(#:tests? #f
> > +       #:configure-flags '("--disable-systemd")))
>
> Maybe use gexp.

Will add in a later commit.

> >     (native-inputs
> >      (list bison flex))
> >     (inputs
> >
> > base-commit: fa92a7c2fe0c5b9e9923ad5f53bafd41aa6dbe66
> > --
> > 2.41.0
>
> Other LGTM

Thanks for the review!





reply via email to

[Prev in Thread] Current Thread [Next in Thread]