[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#68012] [PATCH] services: Add thinkfan service.
From: |
Josselin Poiret |
Subject: |
[bug#68012] [PATCH] services: Add thinkfan service. |
Date: |
Sat, 13 Jan 2024 17:29:08 +0100 |
Hi Luis,
lgcoelho--- via Guix-patches via <guix-patches@gnu.org> writes:
> This patch add thinkfan-service-type to (gnu services pm).
> From 92bf99099f91c0f1dae71b0cf9e5f8e6799a3679 Mon Sep 17 00:00:00 2001
> From: Luis Guilherme Coelho <lgcoelho@disroot.org>
> Date: Sun, 24 Dec 2023 15:52:04 -0300
> Subject: [PATCH] services: Add thinkfan service.
>
> ---
Please add a commit message following the ChangeLog convention. You can
take inspiration from other commits in the repo, and read up on it at [0].
> + (config-file
> + (string "/etc/thinkfan.conf")
> + "Configuration file to use.")
This should not refer to an absolute path. Please use a file-like
instead, users can still use (local-file ...) to give external files.
[0] https://www.gnu.org/prep/standards/html_node/Change-Logs.html
--
Josselin Poiret
signature.asc
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#68012] [PATCH] services: Add thinkfan service.,
Josselin Poiret <=