guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#69074] [PATCH] Add python-angr.


From: Troy Figiel
Subject: [bug#69074] [PATCH] Add python-angr.
Date: Mon, 12 Feb 2024 23:53:55 +0100

Hi Sören,

Just a small note, I had to switch the order of python-pysmt and
python-claripy to be able to apply this patch series. Somehow these are sent 
out of order.

This is not exhaustive, but a couple of things I noticed:

- python-mulpyplexer actually does have tests. The file mulpyplexer.py
  itself is the test.
- python-rpyc seems to have an extensive test suite. Do all of them need
  a network connection? It would be nicer to surgically remove the tests
  that cannot be run.
- python-ailment skips both tests it runs. This might need to be looked
  into or commented why this happens.
- python-angr does not build for me, because a test is failing. I think
  you might have some nondeterministic behaviour in your build:
  --8<---------------cut here---------------start------------->8---
  FAILED test_memory.py::test_concrete_memset - assert 5.379231691360474 <= 5
  --8<---------------cut here---------------end--------------->8---
- Would it make more sense to place python-archinfo and
  python-keystone-engine under engineering.scm? The current placement
  creates a direct import cycle engineering->python-xyz->engineering
- The changes to local.mk and the patches are not mentioned in the
  commit messages.

Best wishes,

Troy





reply via email to

[Prev in Thread] Current Thread [Next in Thread]