[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#69074] [PATCH] Add python-angr.
From: |
Troy Figiel |
Subject: |
[bug#69074] [PATCH] Add python-angr. |
Date: |
Mon, 12 Feb 2024 23:53:55 +0100 |
Hi Sören,
Just a small note, I had to switch the order of python-pysmt and
python-claripy to be able to apply this patch series. Somehow these are sent
out of order.
This is not exhaustive, but a couple of things I noticed:
- python-mulpyplexer actually does have tests. The file mulpyplexer.py
itself is the test.
- python-rpyc seems to have an extensive test suite. Do all of them need
a network connection? It would be nicer to surgically remove the tests
that cannot be run.
- python-ailment skips both tests it runs. This might need to be looked
into or commented why this happens.
- python-angr does not build for me, because a test is failing. I think
you might have some nondeterministic behaviour in your build:
--8<---------------cut here---------------start------------->8---
FAILED test_memory.py::test_concrete_memset - assert 5.379231691360474 <= 5
--8<---------------cut here---------------end--------------->8---
- Would it make more sense to place python-archinfo and
python-keystone-engine under engineering.scm? The current placement
creates a direct import cycle engineering->python-xyz->engineering
- The changes to local.mk and the patches are not mentioned in the
commit messages.
Best wishes,
Troy
- [bug#69074] [PATCH] gnu: Add python-keystone-engine., (continued)
- [bug#69074] [PATCH] gnu: Add python-keystone-engine., soeren, 2024/02/12
- [bug#69074] [PATCH] gnu: Add python-claripy., soeren, 2024/02/12
- [bug#69074] [PATCH] gnu: Add python-archinfo., soeren, 2024/02/12
- [bug#69074] [PATCH] gnu: Add python-pysmt., soeren, 2024/02/12
- [bug#69074] [PATCH] gnu: capstone: Backport upstream fix for Python bindings., soeren, 2024/02/12
- [bug#69074] [PATCH] gnu: unicorn: Update to 2.0.1.post1., soeren, 2024/02/12
- [bug#69074] [PATCH] gnu: Add python-angr., soeren, 2024/02/12
- [bug#69074] [PATCH] gnu: Add python-ailment., soeren, 2024/02/12
- [bug#69074] [PATCH] gnu: Add python-cle., soeren, 2024/02/12
- [bug#69074] [PATCH] gnu: Add python-pyvex., soeren, 2024/02/12
- [bug#69074] [PATCH] Add python-angr.,
Troy Figiel <=
[bug#69074] [PATCH] gnu: Add python-pysmt., Troy Figiel, 2024/02/15
[bug#69074] [PATCH] gnu: Add python-angr., Troy Figiel, 2024/02/15