[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#69783] [PATCH]: website: Convert old style sheets into a theme
From: |
Luis Felipe |
Subject: |
[bug#69783] [PATCH]: website: Convert old style sheets into a theme |
Date: |
Thu, 14 Mar 2024 20:16:34 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 |
Hi Florian, thank you very much for reviewing.
El 14/03/24 a las 16:56, pelzflorian (Florian Pelz) escribió:
the patch looks good, although I will not push it as I do not know where
the CSS file for manuals is set (guix repo? maintenance?). And,
It seems the stylesheets for the manuals are set in
https://git.savannah.gnu.org/cgit/guix.git/tree/doc/build.scm.
* themes is a name clash with haunt themes
<https://files.dthompson.us/docs/haunt/latest/Blog.html#index-theme>,
which may be OK nonetheless. But theme could also be named style or
something. Or not. The name themes is quite fitting.
Yeah, personally, I don't mind using the |themes| concept for both the
SXML components and the CSS stylesheets because of their relation. But I
wouldn't mind using |styles| if necessary. So, if you prefer the latter,
let me know and I'll update the patch.
* I wonder, why are static/base/img/icon and scientific-mark.svg created
and not moved?
Right, they are leftovers. I can provide an updated patch to fix that.
OpenPGP_0x0AB0D067012F08C3.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
- [bug#69783] [PATCH]: website: Convert old style sheets into a theme, Luis Felipe, 2024/03/13
- [bug#69783] [PATCH]: website: Convert old style sheets into a theme, pelzflorian (Florian Pelz), 2024/03/14
- [bug#69783] [PATCH]: website: Convert old style sheets into a theme,
Luis Felipe <=
- [bug#69783] [PATCH v2] website: Convert old style sheets into a theme., sirgazil, 2024/03/15
- [bug#69783] [PATCH] doc: build: Update paths to style sheets., sirgazil, 2024/03/15
- bug#69783: [PATCH] doc: build: Update paths to style sheets., Giovanni Biscuolo, 2024/03/16
- [bug#69783] [PATCH] doc: build: Update paths to style sheets., pelzflorian (Florian Pelz), 2024/03/16
- [bug#69783] [PATCH] doc: build: Update paths to style sheets., Luis Felipe, 2024/03/16
- [bug#69783] [PATCH] doc: build: Update paths to style sheets., pelzflorian (Florian Pelz), 2024/03/16
- [bug#69783] [PATCH] doc: build: Update paths to style sheets., Giovanni Biscuolo, 2024/03/17
- [bug#69783] [PATCH] doc: build: Update paths to style sheets., pelzflorian (Florian Pelz), 2024/03/17