[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#69502] [PATCH] gnu: sdl2: Update to 2.30.0.
From: |
John Kehayias |
Subject: |
[bug#69502] [PATCH] gnu: sdl2: Update to 2.30.0. |
Date: |
Mon, 25 Mar 2024 01:04:21 +0000 |
Hi Dan,
On Wed, Mar 06, 2024 at 02:37 PM, dan wrote:
> Hi John,
>
> On 3/6/2024 1:46 PM, John Kehayias wrote:
>> I'm guessing the slight style change is from guix style, which can be
>> fine (here seems okay to me and more typical), but
> > ...
>> these last changes all seem superfluous to me, not really improving the
>> style.
>
> I ran guix style on sdl2 and that's the result. I'm not sure if I should
> stick to the result of guix style or it's better to not introduce any
> style change and only update needed things. I can send a v2 update if it
> would be easier for you.
Yeah, guix style is not perfect. I don't think it gets used as much as
would be needed to iron out some rough spots either.
In this case, as a simple upgrade to a package, I would normally just
run 'guix lint' on it (if that). Unless there is some clearly
unfavorable style, or a commit to update to e.g. gexps, I would just
leave an existing package as is.
So, I would say just a patch with the version upgrade here would be
cleaner. I will finally get mesa-updates building, including this
patch, in the next few days.
Thanks!
John