guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#69414] [bug#69911] [PATCH gnome-team 0/6] GNOME 44.10 update


From: Liliana Marie Prikler
Subject: [bug#69414] [bug#69911] [PATCH gnome-team 0/6] GNOME 44.10 update
Date: Wed, 27 Mar 2024 18:53:45 +0100
User-agent: Evolution 3.46.4

Am Mittwoch, dem 27.03.2024 um 12:23 +0000 schrieb Christopher Baines:
> 
> Christopher Baines <mail@cbaines.net> writes:
> 
> > Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> > 
> > > Hi Christopher,
> > > 
> > > Christopher Baines <mail@cbaines.net> writes:
> > > 
> > > > Vivien Kraus <vivien@planete-kraus.eu> writes:
> > > > 
> > > > > Hello,
> > > > > 
> > > > > Le mercredi 20 mars 2024 à 10:42 +0000, Christopher Baines a
> > > > > écrit :
> > > > > > Is there anything that needs to happen before gnome-team
> > > > > > can be
> > > > > > merged?
> > > > > 
> > > > > There are concerning failures, such as lightdm, that must be
> > > > > investigated. QA has also highlighted flaky tests in a bunch
> > > > > of
> > > > > packages, and a time-bomb (kcalendarcore).
> > > > 
> > > > I had a go to looking in to lightdm not building and it looks
> > > > to maybe
> > > > be dbus related, but I've got no idea really. Debian and
> > > > nixpkgs don't
> > > > even run the test suite as far as I can tell. I also tried the
> > > > system
> > > > test and that seems to pass. So maybe we raise the issue with
> > > > upstream
> > > > and disable the testsuite for now.
> > > 
> > > I'd rather we spend a bit of time investigating the underlying
> > > failure
> > > and engage with upstream if there's a need.  Setting #:tests? #f
> > > is
> > > easy, but it means the sometimes serious efforts that were needed
> > > to
> > > enable the test suite go into bitrot, making it harder to re-
> > > enable at
> > > a later time (thus unlikely).
> > 
> > To elaborate on the point I'm trying to make, having spent a bit of
> > time
> > looking in to this specific issue, I don't think it's worth
> > blocking the
> > gnome-team merge over an issue with running the lightdm testsuite.
> > 
> > Obviously if there's actually an issue with lightdm, then that's
> > different. This is also somewhat personal since I've got almost no
> > knowledge about lightdm or the dbus problems I suspect might be
> > related.
> 
> Thanks to Vivian's patch (#69948) we're now building lightdm with an
> older dbus.
> 
> I had a look for failures in QA and I didn't really see
> anything. There's some issue with the tests for gtk on aarch64-linux,
> not sure what's going on there, but I don't think that blocks
> merging.
> 
> Is there anything that needs to happen before gnome-team can be
> merged?
QA also LGTM, let's get this merged.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]