[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#71111] [PATCH v2 1/1] services: home: Use pairs instead of lists.
From: |
Andrew Tropin |
Subject: |
[bug#71111] [PATCH v2 1/1] services: home: Use pairs instead of lists. |
Date: |
Thu, 23 May 2024 09:53:44 +0400 |
* gnu/services/guix.scm: Use pairs instead of lists.
* doc/guix.texi: Update accordingly.
* gnu/tests/guix.scm: Update accordingly.
Change-Id: I0b8d3fa5b214add89bdb84a11fa20d1b319435f0
---
doc/guix.texi | 4 ++--
gnu/services/guix.scm | 6 ++++--
gnu/tests/guix.scm | 2 +-
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 8073e3f6d4..8cc5edc805 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -39576,7 +39576,7 @@ Guix Services
(operating-system
(services (append (list (service guix-home-service-type
- `(("alice" ,my-home))))
+ `(("alice" . ,my-home))))
%base-services)))
@end lisp
@@ -39585,7 +39585,7 @@ Guix Services
@lisp
(simple-service 'my-extra-home home-service-type
- `(("bob" ,my-extra-home))))
+ `(("bob" . ,my-extra-home))))
@end lisp
@end defvar
diff --git a/gnu/services/guix.scm b/gnu/services/guix.scm
index 96f5ecaac0..3818749baa 100644
--- a/gnu/services/guix.scm
+++ b/gnu/services/guix.scm
@@ -696,7 +696,7 @@ (define guix-data-service-type
(define (guix-home-shepherd-service config)
(map (match-lambda
- ((user he)
+ (((? string? user) . (? home-environment? he))
(shepherd-service
(documentation "Activate Guix Home.")
(requirement '(user-processes))
@@ -710,7 +710,9 @@ (define (guix-home-shepherd-service config)
(list (string-append "HOME=" (passwd:dir (getpw #$user)))
"GUIX_SYSTEM_IS_RUNNING_HOME_ACTIVATE=t")
#:group (group:name (getgrgid (passwd:gid (getpw
#$user))))))
- (stop #~(make-kill-destructor)))))
+ (stop #~(make-kill-destructor))))
+ (e (error "Invalid value for guix-home, it should be in a form of
+(\"user-name\" . home-environment), but the following value is provided:\n"
e)))
config))
(define guix-home-service-type
diff --git a/gnu/tests/guix.scm b/gnu/tests/guix.scm
index 12ad1bf255..6071cb018e 100644
--- a/gnu/tests/guix.scm
+++ b/gnu/tests/guix.scm
@@ -271,7 +271,7 @@ (define %guix-home-service-he
(define %guix-home-service-os
(simple-operating-system
(service guix-home-service-type
- `(("alice" ,%guix-home-service-he)))))
+ `(("alice" . ,%guix-home-service-he)))))
(define (run-guix-home-service-test)
(define os
--
2.41.0
- [bug#71111] [PATCH 0/1] services: home: Use pairs instead of lists., Andrew Tropin, 2024/05/22
- [bug#71112] [PATCH 1/1] services: home: Use pairs instead of lists., Andrew Tropin, 2024/05/22
- [bug#71111] [PATCH 1/1] services: home: Use pairs instead of lists., Andrew Tropin, 2024/05/22
- [bug#71111] [PATCH 0/1] services: home: Use pairs instead of lists., Richard Sent, 2024/05/22
- [bug#71111] [PATCH 0/1] services: home: Use pairs instead of lists., Zheng Junjie, 2024/05/22
- [bug#71111] [PATCH v2 0/1] services: home: Use pairs instead of lists., Andrew Tropin, 2024/05/23
- [bug#71111] [PATCH v2 1/1] services: home: Use pairs instead of lists.,
Andrew Tropin <=