[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#72674] [PATCH] gnu: guix: Remove unnecessary dependencies.
From: |
Janneke Nieuwenhuizen |
Subject: |
[bug#72674] [PATCH] gnu: guix: Remove unnecessary dependencies. |
Date: |
Sat, 17 Aug 2024 09:13:57 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Ludovic Courtès writes:
Hi!
> Removing this extra dependencies make it simpler to build the ‘guix’
> package in particular on less-capable systems like i586-gnu.
> As Janneke noted in <https://issues.guix.gnu.org/72643#7-lineno16>,
> the new imagemagick dependency made it harder to get ‘guix’ built on
> i586-gnu. It’s also unnecessary.
Nice catch!
> diff --git a/manifest.scm b/manifest.scm
> index 7e4d82c3a5..27e1d62566 100644
> --- a/manifest.scm
> +++ b/manifest.scm
> @@ -24,11 +24,25 @@
> ;;
> ;; guix shell --pure -m manifest.scm hello ...
>
> +(use-modules (guix packages))
> +
> (concatenate-manifests
> - (list (package->development-manifest (specification->package "guix"))
> + (list (package->development-manifest
> + (let ((guix (specification->package "guix")))
> + (package/inherit guix
> + ;; Replace with non-minimal Graphviz for PDF support.
> + (native-inputs (modify-inputs (package-native-inputs guix)
> + (replace "graphviz"
> + (specification->package "graphviz")))))))
> +
> ;; Extra packages used by unit tests.
> (specifications->manifest (list "gnupg"))
>
> + ;; Packages needed for 'make dist' and 'make distcheck'.
> + (specifications->manifest
> + (list "imagemagick"
> + "perl"))
> +
Would it be overkill to avoid this for target-hurd?, someting like
(use-modules (guix utils)
;; ...
(specifications->manifest
(if (target-hurd?)
'()
(list "imagemagick"
"perl"))
Maybe it's premature; as I'm not even sure if fails to builds natively;
some of its dependencies don't cross-build, but it may just build on the
Hurd? I haven't built a guix checkout in a childhurd for some time...
Greetings,
Janneke
--
Janneke Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com