guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#72925] Adding JPM package for Janet


From: Suhail Singh
Subject: [bug#72925] Adding JPM package for Janet
Date: Fri, 04 Oct 2024 23:11:30 -0400
User-agent: Gnus/5.13 (Gnus v5.13)

Omar Bassam <omar.bassam88@gmail.com> writes:

> I just submitted a new path v8. I tested in a pure container shell

Thank you.

> Can you please have another look and let me know if you have any comments

I was unable to cleanly apply v8 on master.  Additionally, it still had
some issues as reported by "guix lint".  I cleaned them up and also made
some simplifications, removed unnecessary dependencies, and fixed a bug
I observed.  I'll make a few comments on v8 for your awareness, but will
also share a v9 with my changes.

Please review v9, and if you agree with the changes mark it as
"reviewed-looks-good".  Please see
<https://libreplanet.org/wiki/Group:Guix/PatchReviewSessions2024> for
details on how to add the reviewed-looks-good usertag.

-- 
Suhail





reply via email to

[Prev in Thread] Current Thread [Next in Thread]