[bug#72398] [PATCH] services: Add readymedia-service-type.

[Fabio Natali]

On 2024-10-18, 02:19 +0100, Arun Isaac <arunisaac@systemreboot.net> wrote:
> I am sending you a final updated patch v8. I have modified the
> indentation of the code, removed single-letter variable names, reduced
> the number of variables, etc. I believe everything works. But, if you
> could try it out and confirm, I'll push it.

Hey Arun,

Thanks and sorry, this might have taken quite a bit of your time, it's a
non-trivial clean-up.

I've checked all the changes and rerun an end-to-end test in a VM.
Everything looks good - we're good to go! :)

Thanks for the introduction of '@acronym{}' in the docs and 'match',
'match-lambda', and 'match-record' in the code, which simplify things
quite a bit. Thanks for some stylistic improvements here and there.

Perhaps the only change I'd do at this point is around one or two
overflowing lines, personally I'd truncate them down to fit the 80-char
limit. Not a big deal and I'm also happy with v8 as it is.

Given all the help given, have you considered adding your name to the
file header?

Thanks, cheers, Fabio.


-- 
Fabio Natali
https://fabionatali.com