guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#74180] [PATCH] gnu: add bash-preexec


From: Javier Olaechea
Subject: [bug#74180] [PATCH] gnu: add bash-preexec
Date: Mon, 4 Nov 2024 04:27:45 +0000


> +
> +       (sha256
> +        (base32 "0nx0m1bhm4f4v033ngi2m9zq3vppimsmn8kmwqbvyqr4n6gkjmgq"))))
> +    (build-system gnu-build-system)

Looks like you can simply use the copy-build-system here, no?

Good call, I've updated the the package to do so. One thing I changed as well is the location for bash-preexec.sh. I saw arch (https://gitlab.archlinux.org/archlinux/packaging/packages/bash-preexec/-/blob/main/PKGBUILD?ref_type=heads#L30) and nix package it under share/ instance of bin/. 

Another thing I did was filtering the test files from the package. As they require the bats package to run.
 
> +    (description
> +     "preexec and precmd hook functions for Bash 3.1+ in the style of
> Zsh.")

The description should be more descriptive. You can describe the two
functions like they do in the README.  Use @command{bash/zsh}.  Prefix
with "This package provides".

Updated accordingly. Let me know if there are any other improvements

--
"I object to doing things that computers can do." — Olin Shivers

Attachment: v2-0001-gnu-add-bash-preexec.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]