[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#66545] [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
From: |
Maxim Cournoyer |
Subject: |
[bug#66545] [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow. |
Date: |
Tue, 12 Nov 2024 23:12:30 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hello,
Rostislav Svoboda <rostislav.svoboda@gmail.com> writes:
>> The tests should not be byte compilation. In fact, these files should be
>> compiled by the build phase.
>
> I see now that the emacs-build-system 'byte compiles all Emacs Lisp
> files.' Then, I think the entire `(arguments ...)` can be elided. If
> this is correct, I am resending the patch (see attachment). If not,
> please direct me to some examples or explain in more detail how to
> byte-compile the *.el file during the build phase. Thank you.
>
> (FYI the code under #:test-command was from
> https://github.com/purcell/color-theme-sanityinc-tomorrow/blob/d34e8db507ee0c7b465ff18a8f220c33ed77cd79/run-tests.sh)
>
> From 1ab65dedbca8d38cf9291e93265cf48c0e473a58 Mon Sep 17 00:00:00 2001
> Message-ID:
> <1ab65dedbca8d38cf9291e93265cf48c0e473a58.1697312893.git.Rostislav.Svoboda@gmail.com>
> From: Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
> Date: Sat, 14 Oct 2023 19:17:22 +0200
> Subject: [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.
>
> * gnu/packages/emacs-xyz.scm (emacs-color-theme-sanityinc-tomorrow): New
> variable.
> ---
> gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index bb8c25f9b5..b5fd851b38 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -11057,6 +11057,30 @@ (define-public emacs-moe-theme-el
> variants.")
> (license license:gpl3+)))
>
> +(define-public emacs-color-theme-sanityinc-tomorrow
I've added this comment here:
;; Use the latest commit as there are no release/tag.
We always justify why using a made-up version or random commit, to help
the next person who'll update the package.
--
Thanks,
Maxim
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#66545] [PATCH] gnu: Add emacs-color-theme-sanityinc-tomorrow.,
Maxim Cournoyer <=