[gurlchecker-users] Re: [gurlchecker] crash of 0.6.0-pre2

[James Antill]

Emmanuel Saracco <address@hidden> writes:

> Le lun 04/08/2003 à 16:00, James Antill a écrit :
> 
> hi james,
> 
> > (This bug report was generated by Bug Buddy 2.2.104)
> > Description of Problem:
> >  doing a check on "sophia.and.org" still crashes with pre2.
> > 
> > How often does this happen?
> >  Always.
> > 
> > Additional Information:
> >  It has read.html in the top box and http://www.sojourner.org/ in the
> > bottom one as it crashes.
> 
> thanks for reporting this.
> 
> unfortunately I can not reproduce the crash :-(
> 
> could you send me the following informations:
> 
> 1/ system + version?

 RH-8.0 with most of ximian desktop 2.

> 2/ are you using a proxy?

 Yes.

> 3/ libgnomeui, libglade and glib versions?

 This might be easier...

% ldd /usr/bin/gurlchecker | awk '{ print $3 }' | xargs rpm -qf | sort | uniq

audiofile-0.2.3-3
bonobo-activation-2.2.2-0.ximian.5.1
esound-0.2.28-1
expat-1.95.4-1
file /lib/libcrypto.so.2 is not owned by any package
file /lib/libssl.so.2 is not owned by any package
file /usr/lib/libjpeg.so.62 is not owned by any package
fontconfig-2.2.0-0.ximian.5.3
freetype-2.1.4-0.ximian.5.3
GConf2-2.2.0-0.ximian.5.6
glib2-2.2.2-0.ximian.5.1
glibc-2.3.2-4.80.6
gnome-vfs2-2.2.5-0.ximian.5.14
gtk2-2.2.2-0.ximian.5.1
libart_lgpl-2.3.12-0.ximian.5.2
libbonobo-2.2.2-0.ximian.5.1
libbonoboui-2.2.2-0.ximian.5.1
libglade2-2.0.1-0.ximian.5.7
libgnome-2.2.1-0.ximian.5.2
libgnomecanvas-2.2.1-0.ximian.5.2
libgnomeui-2.2.0.1-0.ximian.5.6
libxml2-2.5.7-0.ximian.5.2
linc-1.0.2-0.ximian.5.1
ORBit2-2.6.2-0.ximian.5.2
pango-1.2.1-0.ximian.5.5
popt-1.7-1.06
XFree86-libs-4.2.1-21
Xft-2.2-0.ximian.5.5
zlib-1.1.4-8.8x


> 4/ could you send me your "~/.gnome2/gurlchecker-properties" directory?

 It's at...

http://www.and.org/gurl-prop.tar

...and I changed the sleep time to 2 seconds, so it would crash fater.

> -> can you reproduce it with the actual CVS unstable version (I have
> corrected a bug in url.c)?

 The patch at...

http://savannah.nongnu.org/cgi-bin/viewcvs/gurlchecker/gurlchecker/src/url.c.diff?r1=1.21&r2=1.20

...doesn't seem to do anything. It crashed at the same place (even
when I start from sophia.and.org/read.html instead), and the final
message is "Parsing HTML code (founded 1 links)..." so I'm guessing
the html parsing code has the error.

 Haha ... it dies immediately on... http://www.sojourner.org/ ...which
is a link on that page.

 Adding some tracers (gdb couldn't give a backtrace), I can see that
it dies on this line...

                  tb->attr = uc_html_parser_get_attributes (tmp);

...and it seems there is a buffer overflow, this fixes my crash...

diff -ru orig/gurlchecker-0.6.0pre2/src/html_parser.c 
gurlchecker-0.6.0pre2/src/html_parser.c
--- orig/gurlchecker-0.6.0pre2/src/html_parser.c        2003-08-03 
18:07:03.000000000 -0400
+++ gurlchecker-0.6.0pre2/src/html_parser.c     2003-08-04 12:10:41.000000000 
-0400
@@ -449,7 +449,7 @@
       html_tag = uc_html_parser_node_new (uc_utils_strdup_delim (tag, end));
  
       tag += (end - tag) + 1;
-      while (*tag)
+      while (*tag && (i < BUFFER_URL_LEN))
        {
          switch (*tag)
            {


 *cough* hyttp://www.and.org/vstr/security.html *cough*

-- 
James Antill -- address@hidden
Need an efficent and powerful string library for C?
http://www.and.org/vstr/