Re: [Gzz-commits] (no subject)

[Tuomas Lukka]

> 1. New Slicer interface. A Slicer is a component of Space on the same
>    level as CellTexter. It's responsibility is to divide a space into
>    slices, allowing slices to be swapped in and out. This means that
>    turning slices into SliceVersions is part of its responsibilities
>    (as attaching and disattaching slices (resolving and recreating
>    preflets) is encapsulated in it).
> 
>    So far, this is only able to get the SliceVersion for s.0 (it is
>    unfinished).

Are you really sure that we want this in gzz and not gzz.impl? Because
this is not really useful for the front-end and gzz is only supposed
to be that interface.

Or possibly its own package?

> 3. In CellTexter, add a Set getCells() method to get the cells that have
>    a content mapping. (The problem is that we need some cooperation from
>    CellTexter for saving, because there might be an infinite number of
>    cells... maybe we should be able to get and set a Map from cells to
>    implementation-defined serializable objects, but that would be less
>    general. OTOH, SingleSlicer currently depends on CellTexter being
>    a VStreamCellTexter: not nice...)

Would prefer getCellsWithContent() or such.

> 4. In Dim, remove addRealNegSides(Set). Instead, put in Set getNegsides().
>    (I discussed this with Tuomas on IRC at some point.) The set contains
>    cells, while addRealNegSides() put in cell ids-- now, we can simply
>    return the keySet() of the Map in the positive direction.

Good

> 5. The javadoc of Space.getDims() reads, "Get the set of all dimensions
>    in this space." I understand this as meaning the set of Dim objects.
>    AbstractDimManager, though, returned Cells. I've changed
>    AbstractDimManager for now and put a comment in Space's javadoc.
>    Tuomas, please decide this and clarify the javadoc in Space.

Since you can get the Dimension's id, returning dims is fine. Doccing.

> 8. Added a second constructor to ModularSpace, taking a SliceVersion from
>    which to initialize the space. I'm not sure where this should be.
>    I do feel that once constructed, a space should have one "starter"
>    slice (s.0)...

Are you sure we want modularspace to know that much about SliceVersions?

        Tuomas