gzz-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gzz-commits] gzz/gfx/libos Os.hxx


From: Tuomas Lukka
Subject: Re: [Gzz-commits] gzz/gfx/libos Os.hxx
Date: Thu, 12 Sep 2002 17:57:13 +0300
User-agent: Mutt/1.4i

> !     /* (WGL\APL\GLX)_ARB_get_proc_address moved to libos from libcallgl
> !      *   because of it's os dependent.
>        * 
> !      * What it does? There are some extended gl calls which need to be 
> !      *  asked from the driver.
> !      */
> !     void (* getExtendedProcAddress(string s))(void);
>   
>   }

Some more comments: 

1) The text
        (WGL\APL\GLX)_ARB_get_proc_address moved to libos from libcallgl
 !      *   because of it's os dependent.
        *
   is ok in a commit message, but in a javadoc/doc++ comment you shouldn't
   talk about it having been moved, especially as the first sentence.
   The first sentence should say what the function does in a concise
   manner; see Sun's instructions on writing javadoc.

2) "What it does?": 
        - don't ask, just explain.

3) "extended gl calls":
        - the standard term would be "OpenGL extension functions",
          and giving an example would be good (e.g. 
          glLoadProgramNV)

So, the last paragraph would be better as 

        OpenGL extension functions may not be defined and referencing
        them may cause linkage errors. Therefore, their addresses
        need to be dynamically queried at run time.

        Tuomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]