Re: [Gzz-commits] gzz/gfx/libcallgl callgl.cxx callgl.hxx

[Tuomas Lukka]

>   
> !     /* vector<string> v = split("  asdf   #  asdffoo fasdf # fadasfd ");
> !      * 0: asdf
>        * 1: #
> !      * 2: asdffoo
> !      * 3: fasdf
> !      * 4: #
> !      * 5: fadasfd
>        */ 

Actually, why doesn't this method already remove the comments? So for
the above string, it would return

        0: asdf

and that's it. Comments after lines are good also.

>       vector<string> split(string str) {
>           string tmp;
> --- 71,80 ----
>   
>   
>   
> !     /* vector<string> v = split("  foo   #  bar ");
> !      * 0: foo
>        * 1: #
> !      * 2: bar
>        */ 
>       vector<string> split(string str) {
>           string tmp;
> ***************
> *** 125,130 ****
> --- 129,135 ----
>       bool callGLop(string s) {
>           DBG(dbg) << "callGLop(\"" << s << "\")\n";
>   
> +     // Substring comment out -- if '#' found 
>           string::size_type position = s.find('#');
>           if (position != string::npos) s = s.substr(0, position);

Because it would belong nicer to the tokenizer than here.

> + // XXX
> + //#define USE_GL_EXTENSION_CALLS
> + #ifdef USE_GL_EXTENSION_CALLS
> + 
> +     } else if (checkfunc(v, "GetProcAddress", 1)) {
> +       if (ext_check.isCallNameFound(v[1])) {

Ouch, I think you have misunderstood what I wanted to happen now.
Because the OpenGL routines *will* have interesting parameters,
we can't really do this, we have to declare them somewhere.
I don't want to do this from Java but to simply use glXGetProcAddress
for all those functions that are not part of core OpenGL v1.1.
For example, all the _NV methods are like that.

        Tuomas