Re: [Gzz-commits] gzz/gfx/util demo.py

[Tuomas Lukka]

On Thu, Jan 02, 2003 at 08:21:59AM -0500, Matti Katila wrote:
> CVSROOT:      /cvsroot/gzz
> Module name:  gzz
> Changes by:   Matti Katila <address@hidden>   03/01/02 08:21:59
> 
> Modified files:
>       gfx/util       : demo.py 
> 
> Log message:
>       Added teasing because I don't know the historical issues with debianism
> 
> CVSWeb URLs:
> http://savannah.gnu.org/cgi-bin/viewcvs/gzz/gzz/gfx/util/demo.py.diff?tr1=1.8&tr2=1.9&r1=text&r2=text
> 
> Patches:
> Index: gzz/gfx/util/demo.py
> diff -u gzz/gfx/util/demo.py:1.8 gzz/gfx/util/demo.py:1.9
> --- gzz/gfx/util/demo.py:1.8  Mon Dec 23 05:34:51 2002
> +++ gzz/gfx/util/demo.py      Thu Jan  2 08:21:59 2003
> @@ -17,7 +17,13 @@
>  import os
>  # Unfortunate debianisms XXX
>  sys.path.insert(0, "/usr/share/jython/Lib")
> -sys.path.insert(0, "/usr/lib/python2.1")
> +
> +# SHOULD be solved somehow! =)
> +print '\n\nWARNING!'
> +print '   Do we really need - sys.path.insert(0, "/usr/lib/python2.1") ?!'
> +print '   It makes things difficult with jython - at least in pp for example'
> +print '   Anyway, have a nice day ;)\n\n'
> +#sys.path.insert(0, "/usr/lib/python2.1")
>  sys.path.insert(0, ".")
>  
>  from java.lang import System,Runnable

Please don't do it like this!

Just remove it and see if the tests work. If they do, just commit.

Remember, YOU'RE ALLOWED TO CHANGE ANYTHING NOT OTHERWISE MARKED THAT
ISN'T CAUGHT BY THE TESTS.

If it should have been there, it's up to the person who needs it to put it back 
in and
make a test for it. It is not your responsibility if you break something that
isn't tested. On the contrary, breaking it is good, since either
1) you remove some crud -- always good
2) you cause tests to be written for necessary functionality -- even better.

Especially now that we have gzz-commits list, don't be afraid to really edit
things.

        Tuomas