gzz-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gzz-commits] gzz/gzz/util CopyUtil.java


From: Tuomas Lukka
Subject: Re: [Gzz-commits] gzz/gzz/util CopyUtil.java
Date: Sun, 19 Jan 2003 11:22:40 +0200
User-agent: Mutt/1.4i

On Sat, Jan 18, 2003 at 06:30:49PM -0500, Benja Fallenstein wrote:
> CVSROOT:      /cvsroot/gzz
> Module name:  gzz
> Changes by:   Benja Fallenstein <address@hidden>      03/01/18 18:30:49
> 
> Modified files:
>       gzz/util       : CopyUtil.java 
> 
> Log message:
>       add convenience method
> 
> CVSWeb URLs:
> http://savannah.gnu.org/cgi-bin/viewcvs/gzz/gzz/gzz/util/CopyUtil.java.diff?tr1=1.2&tr2=1.3&r1=text&r2=text
> 
> Patches:
> Index: gzz/gzz/util/CopyUtil.java
> diff -u gzz/gzz/util/CopyUtil.java:1.2 gzz/gzz/util/CopyUtil.java:1.3
> --- gzz/gzz/util/CopyUtil.java:1.2    Sat Nov 16 00:59:45 2002
> +++ gzz/gzz/util/CopyUtil.java        Sat Jan 18 18:30:49 2003
> @@ -65,4 +65,8 @@
>       copy(in, out);
>       return out.toByteArray();
>      }
> +
> +    static public String readString(InputStream in) throws IOException {
> +     return new String(readBytes(in));
> +    }
>  }

Uhh, you should probably see the docstring of new String(byte[]) - it's
probably not exactly what you want. It would be better to specify
an encoding and also say it in the docstring.

        Tuomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]