Re: [Health-dev] Commenting XML block

[Luis Falcon]

On Fri, 18 Dec 2015 13:14:55 +0100
Cédric Krier <address@hidden> wrote:

> On 2015-12-18 11:30, Luis Falcon wrote:
> > On Fri, 18 Dec 2015 12:11:41 +0100
> > Cédric Krier <address@hidden> wrote:  
> > > For me, it is OK to put some comments in the XML view to guide
> > > developers.
> > > But it is not OK to comment parts of the view for history reason.
> > > The history is managed by the VCS. This behaviour is similar to
> > > commenting code because it is no more used. This is often
> > > considered as bad practice and I think GNU Health should consider
> > > the same.  
> > It makes sense. Agree on those terms.  
> 
> But do you agree that such things [1] should not be done.
> It brings no value, make the view more difficult to read and odds that
> it will be forgot to be removed.
> 
Done in http://hg.savannah.gnu.org/hgweb/health/rev/c6bda871e589

> > I propose having the method on tryton to strip XML
> > comment blocks from the DB instance to make the views lighter. Of
> > course, the original XML view file and its comments would remain the
> > same.  
> 
> Done with https://bugs.tryton.org/issue5189
> 
Great !! That was fast ;-)
> 
> [1] http://hg.savannah.gnu.org/hgweb/health/rev/8c645af9b265#l1.14
>

pgpZr05tJAUKW.pgp
Description: OpenPGP digital signature