Re: [Help-bash] Current working directory echoed to the terminal

[Greg Wooledge]

On Mon, Apr 09, 2012 at 04:37:30PM -0400, Chris Jones wrote:
> The BASH_ENV variable points to this:
> 
> | if [ -d /etc/bash_functions ]; then
> |     cd /etc/bash_functions
> |     for i in $(ls); do
> |             . $i
> |     done
> |     cd -
> | fi

In addition to what Bob and Eric said, this could be better written:

if [ -d /etc/bash_functions ]; then
    for i in /etc/bash_functions/*; do
        . "$i"
    done
fi

That would avoid the issue with unwanted "cd -" output, and also avoid
issues caused by filenames with spaces in them, on which $(ls) will break
quite badly.